Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve type support for fbrlogger #3238

Merged
merged 7 commits into from
Jun 28, 2024
Merged

improve type support for fbrlogger #3238

merged 7 commits into from
Jun 28, 2024

Conversation

leej3
Copy link
Collaborator

@leej3 leej3 commented Apr 22, 2024

No description provided.

@github-actions github-actions bot added the module: handlers Core Handlers module label Apr 22, 2024
@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 2, 2024

@leej3 do you think it is possible to fix the CI here?

@vfdev-5 vfdev-5 deleted the branch pytorch:master June 14, 2024 12:41
@vfdev-5 vfdev-5 closed this Jun 14, 2024
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 14, 2024 •
edited
Loading

@leej3 can you please reopen this PR and change the merging branch to master?

EDIT: could finally do that myself

@vfdev-5 vfdev-5 reopened this Jun 14, 2024
@vfdev-5 vfdev-5 changed the base branch from update-fbrlogger- to master June 14, 2024 12:43
@github-actions github-actions bot added module: utils Utils module module: metrics Metrics module labels Jun 18, 2024
vfdev-5
vfdev-5 reviewed Jun 19, 2024
View reviewed changes
ignite/utils.py Outdated Show resolved Hide resolved
@leej3 leej3 force-pushed the fix-type-issue branch 2 times, most recently from 1e37dce to a247969 Compare June 25, 2024 11:07
@github-actions github-actions bot added the docs label Jun 25, 2024
vfdev-5
vfdev-5 reviewed Jun 26, 2024
View reviewed changes
docs/source/utils.rst Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few questions to clarify and we can land it.
Failing tpu jobs is unrelated

@vfdev-5 vfdev-5 merged commit 5a66d9e into pytorch:master Jun 28, 2024
19 of 20 checks passed
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 28, 2024

Thanks for the fixes, John!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: handlers Core Handlers module module: metrics Metrics module module: utils Utils module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leej3 @vfdev-5